dbddf17e3b
When a guest submitted via their invitation and then forwarded the link
(or someone copied the URL), the recipient was shown the original guest's
response and a "Change my response" button. Two real problems:
- Privacy leak: the original guest's reply was visible
- Integrity: the recipient could silently overwrite the response
The fix is two layered defences plus a recovery path, matching the
industry pattern used by Eventbrite / Partiful / Lu.ma:
Backend
- GET /access/{token} now compares the device fingerprint of the
current request to the fingerprint stored on the existing RSVP.
When they don't match, the rsvp field is omitted from the
response and a new rsvp_submitted_elsewhere flag is set instead.
The original guest's reply stays private.
- PATCH /rsvp/{token} runs the same gate before scoring. A foreign
device gets 403 with a hint to request an edit link.
- The fingerprint check is intentionally narrow (user_agent only),
so a guest jumping between Wi-Fi and mobile data on the same
phone still sails through.
Recovery path
- New POST /access/{token}/request-edit-link mints a short-lived
edit nonce (Redis, 30-min TTL, SHA-256-hashed), then emails it
to the guest's address on file via the existing EmailSender.
Rate-limited to 3 per token per hour.
- GET /access/{token}?edit=<nonce> and PATCH /rsvp with edit_nonce
in the body both accept the nonce as a bypass for the
same-device check. Lets the real guest edit from a new phone
when their original device is gone.
- New SendRSVPEditLink method on auth.EmailSender, implemented by
every concrete sender (log stub / Resend / SMTP / SES), with a
branded HTML+text template that explains the "we sent this
because we didn't recognise the device" framing.
Frontend
- rsvp/[token].vue learns the new "responded elsewhere" state.
Renders "This invitation has already been used" + a
"Send me an edit link" CTA when the access response says we
have somewhere to deliver it. Empty-state copy reads "If you
forwarded the link, please ask the original guest to reach
out to the host".
- When the URL carries ?edit=<nonce>, the page passes it on the
/access call (so the backend unhides the RSVP), opens the edit
form pre-populated, and forwards the nonce on PATCH.
- Removed two leftover leaks from earlier — the page no longer
shows internal "Risk score N · band" to confirmed or blocked
guests; the blocked-attempt copy now reads "Something about
this attempt looked off" rather than "suspicious access
attempt".
Defensive nil-guard
- The access handler's NATS publish goroutine now skips when
deps.AccessPublisher is nil (matches the rsvp publisher's
existing guard); without it the handler nil-panicked in tests
that don't wire NATS.
Tests
- TestFingerprintsSimilar (unit) covers the same-UA / different-UA
/ missing-UA matrix.
- TestForwardedInvitationLinkDefence (integration) walks the full
flow: submit from UA-A, hide on UA-B, request link, follow nonce
from UA-B and edit, then verify a UA-C with a forged nonce is
still refused.
- Full integration suite passes (183.5s).
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
119 lines
3.3 KiB
Go
119 lines
3.3 KiB
Go
package notification
|
|
|
|
import (
|
|
"bytes"
|
|
"embed"
|
|
"fmt"
|
|
htmltemplate "html/template"
|
|
"io/fs"
|
|
"path"
|
|
"strings"
|
|
texttemplate "text/template"
|
|
)
|
|
|
|
//go:embed templates
|
|
var templatesFS embed.FS
|
|
|
|
// TemplateName names one of the email templates. There must be a
|
|
// matching `<name>.html` and `<name>.txt` under templates/.
|
|
type TemplateName string
|
|
|
|
const (
|
|
TmplVerification TemplateName = "verification"
|
|
TmplPasswordReset TemplateName = "reset"
|
|
TmplInvitation TemplateName = "invitation"
|
|
TmplConfirmation TemplateName = "confirmation"
|
|
TmplReminder TemplateName = "reminder"
|
|
TmplCollaboratorInvite TemplateName = "collaborator_invite"
|
|
TmplRSVPEditLink TemplateName = "rsvp_edit_link"
|
|
)
|
|
|
|
// Templates renders branded transactional emails for both HTML and
|
|
// plaintext bodies. Loaded once at construction; thread-safe afterwards.
|
|
//
|
|
// Each page-level HTML template gets its own *html/template.Template
|
|
// holding a copy of the `base.html` partial. This avoids html/template's
|
|
// per-template contextual-escape pass interfering between pages that all
|
|
// define a sibling named "body".
|
|
type Templates struct {
|
|
html map[string]*htmltemplate.Template // page-name (no ext) -> root
|
|
text *texttemplate.Template
|
|
}
|
|
|
|
func NewTemplates() (*Templates, error) {
|
|
root, err := fs.Sub(templatesFS, "templates")
|
|
if err != nil {
|
|
return nil, fmt.Errorf("templates fs: %w", err)
|
|
}
|
|
|
|
baseHTML, err := fs.ReadFile(root, "base.html")
|
|
if err != nil {
|
|
return nil, fmt.Errorf("read base.html: %w", err)
|
|
}
|
|
|
|
out := &Templates{
|
|
html: make(map[string]*htmltemplate.Template),
|
|
text: texttemplate.New("__root__"),
|
|
}
|
|
|
|
walk := func(p string, d fs.DirEntry, _ error) error {
|
|
if d == nil || d.IsDir() {
|
|
return nil
|
|
}
|
|
base := path.Base(p)
|
|
if base == "base.html" {
|
|
return nil // partial — folded into each page template below
|
|
}
|
|
b, err := fs.ReadFile(root, p)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
switch {
|
|
case strings.HasSuffix(p, ".html"):
|
|
name := strings.TrimSuffix(base, ".html")
|
|
t := htmltemplate.New(name)
|
|
if _, err := t.Parse(string(baseHTML)); err != nil {
|
|
return fmt.Errorf("parse _base for %s: %w", p, err)
|
|
}
|
|
if _, err := t.Parse(string(b)); err != nil {
|
|
return fmt.Errorf("parse %s: %w", p, err)
|
|
}
|
|
out.html[name] = t
|
|
case strings.HasSuffix(p, ".txt"):
|
|
if _, err := out.text.New(base).Parse(string(b)); err != nil {
|
|
return fmt.Errorf("parse %s: %w", p, err)
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
if err := fs.WalkDir(root, ".", walk); err != nil {
|
|
return nil, err
|
|
}
|
|
return out, nil
|
|
}
|
|
|
|
// Render returns (htmlBody, textBody) for the named template using data.
|
|
func (t *Templates) Render(name TemplateName, data map[string]any) (htmlBody, textBody string, err error) {
|
|
if data == nil {
|
|
data = map[string]any{}
|
|
}
|
|
if _, ok := data["Subject"]; !ok {
|
|
data["Subject"] = "GuestGuard"
|
|
}
|
|
|
|
htmlTpl, ok := t.html[string(name)]
|
|
if !ok {
|
|
return "", "", fmt.Errorf("unknown html template %q", name)
|
|
}
|
|
|
|
var hBuf, tBuf bytes.Buffer
|
|
// Each page-root template's entry point is "base" (defined by base.html).
|
|
if err := htmlTpl.ExecuteTemplate(&hBuf, "base", data); err != nil {
|
|
return "", "", fmt.Errorf("render html %s: %w", name, err)
|
|
}
|
|
if err := t.text.ExecuteTemplate(&tBuf, string(name)+".txt", data); err != nil {
|
|
return "", "", fmt.Errorf("render text %s: %w", name, err)
|
|
}
|
|
return hBuf.String(), tBuf.String(), nil
|
|
}
|