dbddf17e3b
When a guest submitted via their invitation and then forwarded the link
(or someone copied the URL), the recipient was shown the original guest's
response and a "Change my response" button. Two real problems:
- Privacy leak: the original guest's reply was visible
- Integrity: the recipient could silently overwrite the response
The fix is two layered defences plus a recovery path, matching the
industry pattern used by Eventbrite / Partiful / Lu.ma:
Backend
- GET /access/{token} now compares the device fingerprint of the
current request to the fingerprint stored on the existing RSVP.
When they don't match, the rsvp field is omitted from the
response and a new rsvp_submitted_elsewhere flag is set instead.
The original guest's reply stays private.
- PATCH /rsvp/{token} runs the same gate before scoring. A foreign
device gets 403 with a hint to request an edit link.
- The fingerprint check is intentionally narrow (user_agent only),
so a guest jumping between Wi-Fi and mobile data on the same
phone still sails through.
Recovery path
- New POST /access/{token}/request-edit-link mints a short-lived
edit nonce (Redis, 30-min TTL, SHA-256-hashed), then emails it
to the guest's address on file via the existing EmailSender.
Rate-limited to 3 per token per hour.
- GET /access/{token}?edit=<nonce> and PATCH /rsvp with edit_nonce
in the body both accept the nonce as a bypass for the
same-device check. Lets the real guest edit from a new phone
when their original device is gone.
- New SendRSVPEditLink method on auth.EmailSender, implemented by
every concrete sender (log stub / Resend / SMTP / SES), with a
branded HTML+text template that explains the "we sent this
because we didn't recognise the device" framing.
Frontend
- rsvp/[token].vue learns the new "responded elsewhere" state.
Renders "This invitation has already been used" + a
"Send me an edit link" CTA when the access response says we
have somewhere to deliver it. Empty-state copy reads "If you
forwarded the link, please ask the original guest to reach
out to the host".
- When the URL carries ?edit=<nonce>, the page passes it on the
/access call (so the backend unhides the RSVP), opens the edit
form pre-populated, and forwards the nonce on PATCH.
- Removed two leftover leaks from earlier — the page no longer
shows internal "Risk score N · band" to confirmed or blocked
guests; the blocked-attempt copy now reads "Something about
this attempt looked off" rather than "suspicious access
attempt".
Defensive nil-guard
- The access handler's NATS publish goroutine now skips when
deps.AccessPublisher is nil (matches the rsvp publisher's
existing guard); without it the handler nil-panicked in tests
that don't wire NATS.
Tests
- TestFingerprintsSimilar (unit) covers the same-UA / different-UA
/ missing-UA matrix.
- TestForwardedInvitationLinkDefence (integration) walks the full
flow: submit from UA-A, hide on UA-B, request link, follow nonce
from UA-B and edit, then verify a UA-C with a forged nonce is
still refused.
- Full integration suite passes (183.5s).
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
158 lines
4.3 KiB
Go
158 lines
4.3 KiB
Go
package notification
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
"net/http"
|
|
"time"
|
|
)
|
|
|
|
// ResendConfig configures the Resend HTTP sender. APIKey is required;
|
|
// FromEmail is the sending address on a domain you've verified in the
|
|
// Resend dashboard.
|
|
type ResendConfig struct {
|
|
APIKey string
|
|
FromEmail string
|
|
FromName string
|
|
|
|
// HTTPClient overrides the default client (mostly so tests can point
|
|
// at httptest.Server). Leave nil for production.
|
|
HTTPClient *http.Client
|
|
BaseURL string // overrideable for tests; defaults to https://api.resend.com
|
|
}
|
|
|
|
// ResendEmailSender posts emails through https://api.resend.com/emails.
|
|
// Implements auth.EmailSender + GuestEmailDispatcher.
|
|
type ResendEmailSender struct {
|
|
cfg ResendConfig
|
|
tpls *Templates
|
|
from string
|
|
client *http.Client
|
|
url string
|
|
}
|
|
|
|
func NewResendEmailSender(cfg ResendConfig, tpls *Templates) (*ResendEmailSender, error) {
|
|
if cfg.APIKey == "" {
|
|
return nil, errors.New("resend: APIKey required")
|
|
}
|
|
if cfg.FromEmail == "" {
|
|
return nil, errors.New("resend: FromEmail required")
|
|
}
|
|
from := cfg.FromEmail
|
|
if cfg.FromName != "" {
|
|
from = fmt.Sprintf("%s <%s>", cfg.FromName, cfg.FromEmail)
|
|
}
|
|
cli := cfg.HTTPClient
|
|
if cli == nil {
|
|
cli = &http.Client{Timeout: 15 * time.Second}
|
|
}
|
|
base := cfg.BaseURL
|
|
if base == "" {
|
|
base = "https://api.resend.com"
|
|
}
|
|
return &ResendEmailSender{cfg: cfg, tpls: tpls, from: from, client: cli, url: base + "/emails"}, nil
|
|
}
|
|
|
|
// --- auth.EmailSender ---
|
|
|
|
func (s *ResendEmailSender) SendVerification(ctx context.Context, to, name, link string) error {
|
|
_, err := s.sendTemplated(ctx, to, "Verify your GuestGuard email",
|
|
TmplVerification, map[string]any{"Name": name, "Link": link})
|
|
return err
|
|
}
|
|
|
|
func (s *ResendEmailSender) SendPasswordReset(ctx context.Context, to, name, link string) error {
|
|
_, err := s.sendTemplated(ctx, to, "Reset your GuestGuard password",
|
|
TmplPasswordReset, map[string]any{"Name": name, "Link": link, "ExpiryHumane": "1 hour"})
|
|
return err
|
|
}
|
|
|
|
func (s *ResendEmailSender) SendCollaboratorInvite(ctx context.Context, to, inviterName, eventName, role, link string) error {
|
|
_, err := s.sendTemplated(ctx, to,
|
|
inviterName+" invited you to "+eventName,
|
|
TmplCollaboratorInvite, map[string]any{
|
|
"InviterName": inviterName,
|
|
"EventName": eventName,
|
|
"Role": role,
|
|
"Link": link,
|
|
})
|
|
return err
|
|
}
|
|
|
|
func (s *ResendEmailSender) SendRSVPEditLink(ctx context.Context, to, guestName, eventName, link string) error {
|
|
_, err := s.sendTemplated(ctx, to,
|
|
"Edit your RSVP for "+eventName,
|
|
TmplRSVPEditLink, map[string]any{
|
|
"GuestName": guestName,
|
|
"EventName": eventName,
|
|
"Link": link,
|
|
})
|
|
return err
|
|
}
|
|
|
|
// --- GuestEmailDispatcher ---
|
|
|
|
func (s *ResendEmailSender) SendGuest(ctx context.Context, to, subject string, name TemplateName, data map[string]any) (string, error) {
|
|
return s.sendTemplated(ctx, to, subject, name, data)
|
|
}
|
|
|
|
// --- internals ---
|
|
|
|
type resendRequest struct {
|
|
From string `json:"from"`
|
|
To []string `json:"to"`
|
|
Subject string `json:"subject"`
|
|
HTML string `json:"html"`
|
|
Text string `json:"text"`
|
|
}
|
|
|
|
type resendResponse struct {
|
|
ID string `json:"id"`
|
|
Message string `json:"message,omitempty"`
|
|
}
|
|
|
|
func (s *ResendEmailSender) sendTemplated(ctx context.Context, to, subject string, name TemplateName, data map[string]any) (string, error) {
|
|
if data == nil {
|
|
data = map[string]any{}
|
|
}
|
|
data["Subject"] = subject
|
|
html, text, err := s.tpls.Render(name, data)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
|
|
body, _ := json.Marshal(resendRequest{
|
|
From: s.from,
|
|
To: []string{to},
|
|
Subject: subject,
|
|
HTML: html,
|
|
Text: text,
|
|
})
|
|
req, err := http.NewRequestWithContext(ctx, http.MethodPost, s.url, bytes.NewReader(body))
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
req.Header.Set("Authorization", "Bearer "+s.cfg.APIKey)
|
|
req.Header.Set("Content-Type", "application/json")
|
|
|
|
resp, err := s.client.Do(req)
|
|
if err != nil {
|
|
return "", fmt.Errorf("resend: do: %w", err)
|
|
}
|
|
defer resp.Body.Close()
|
|
|
|
respBody, _ := io.ReadAll(io.LimitReader(resp.Body, 64*1024))
|
|
if resp.StatusCode >= 300 {
|
|
return "", fmt.Errorf("resend: status %d: %s", resp.StatusCode, string(respBody))
|
|
}
|
|
var parsed resendResponse
|
|
if err := json.Unmarshal(respBody, &parsed); err != nil {
|
|
return "", fmt.Errorf("resend: parse: %w", err)
|
|
}
|
|
return parsed.ID, nil
|
|
}
|